browsh-org/browsh

Kill the headless Firefox process by PID, not by grepping `ps`

Open

#61 opened on Jul 9, 2018

View on GitHub
 (2 comments) (3 reactions) (0 assignees)JavaScript (15,996 stars) (455 forks)batch import
enhancementhelp wanted

Description

This was first brought up by a user that had an existing Selenium session: #59

If Browsh's Firefox process can have an identifying mark to it, then we can detect that instead of a crude detection of any headless Firefox process.

Contributor guide

Tech stack
javascript
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic Node.jsUnderstanding of child processesFamiliarity with Firefox CLI flags
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Look at how Browsh currently launches Firefox, likely in the browser launcher code. Understand the current method of killing by grepping ps and the issue referenced (#59). Implement a unique identifier (e.g., a custom command line argument like ' browsh pid') to be passed to Firefox, so the process can be killed by PID directly. Ensure the identifier is stored and retrievable after spawning.