browsh-org/browsh

Ability to skip version check

Open

#508 opened on Jan 17, 2024

View on GitHub
 (0 comments) (2 reactions) (1 assignee)JavaScript (15,996 stars) (455 forks)batch import
enhancementhelp wanted

Description

Just the ability to skip the Firefox version check (installed, correct version, etc.), so browsh could be used with any Firefox forks, incl. those with unique version schemas.

Using such flag should also notify the user that it's essentially an unsupported mode. It can only work with firefox.path is provided, because otherwise it tries to resolve the binary path to firefox using which firefox (unix) or registry lookup (Windows).

Ref: https://github.com/browsh-org/browsh/discussions/506

Contributor guide

Tech stack
go
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go basicsCLI flag handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Add a new command line flag (e.g., skip version check) to browsh's CLI argument parsing, likely in main.go. When set, skip the Firefox version check and print a warning that this is unsupported. Ensure the flag requires firefox.path to be provided. Refer to the linked discussion (#506) for more context on Firefox forks with unique version schemas.