browsh-org/browsh

ENTER and ESC keys don't always work

Open

#43 opened on Jun 13, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (455 forks)batch import
bughelp wanted

Repository metrics

Stars
 (15,996 stars)
PR merge metrics
 (PR metrics pending)

Description

For instance on Google News the search box doesn't register the ENTER key.

The ESC can't ever be used to close things like image viewer overlays.

Contributor guide

Research direction
Investigate how keyboard events are handled in browsh, especially for ENTER and ESC. Look at the event propagation in different contexts like search boxes and image overlays.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptGitKeyboard events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60