browsh-org/browsh

ENTER and ESC keys don't always work

Open

#43 opened on Jun 13, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (15,996 stars) (455 forks)batch import
bughelp wanted

Description

For instance on Google News the search box doesn't register the ENTER key.

The ESC can't ever be used to close things like image viewer overlays.

Contributor guide

Tech stack
javascript
Domain
clifrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScript event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how keyboard input is handled in browsh, specifically the event propagation for ENTER and ESC keys. Check the relevant source files that manage key bindings and event forwarding from the terminal to the headless browser. Look at the browser's console for any error messages when pressing these keys. Review the code that translates terminal keypresses to DOM events.