browsh-org/browsh

Passing keys doesn't work

Open

#221 opened on Sep 28, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (15,996 stars) (455 forks)batch import
bughelp wantedtty-mode

Description

I'm using this as a testcase: https://www.w3schools.com/graphics/tryit.asp?filename=trygame_controllers_keys

The arrow keys should move the red rectangle around, but it's not working.

And if you try to edit the code to the left of the game, it seems all you can do is to delete characters with backspace or to insert line breaks with enter, normal characters don't get registered. And the changes to the text only become visible with some delay.

Do we need to use Firefox's marionette protocol to make the passing of input events truly robust? The downside would be that this would tie Browsh even more to Firefox.

Maybe all of these issues are fixable in the webextension.

One more testcase: http://www.gaminglogy.com/tutorial/controls-keyboard/demo/index.html (the sprite is supposed to get moved by the ASDW keys)

Please contribute further testcases to this bug report.

Contributor guide

Tech stack
javascriptnodejs
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of browser events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the webextension's key event handling. Look into how keys are passed from the browser to the underlying TTY or rendering engine. Check if the issue is related to the webextension or the Marionette protocol as suggested. Review the test cases provided (W3Schools and Gaminglogy) to reproduce the failure.