Better error handling
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- tooling
Research direction
Start by tracing how static-eval currently returns and checks the FAIL object during AST evaluation, especially for unsupported expressions such as NewExpression. Review the Error proposal and the evaluator's public entry point; done means failures provide useful error information instead of indistinguishable undefined results.
Written by the indexing model from the issue text.
Description
This is a good project but it's very hard to know what's wrong. We only know when there is a problem by getting undefined.. But if the expression does not return anything and only have a side effect then we don't even know if the code was executed or if there was a problem in the AST.
I suggest static-eval could use Errors instead of the FAIL object. This way it would not be needed to check everytime of something is equal fo FAIL and the end user would get more information about the error.
For example I spent 30 minutes figuring out why I was receiving undefined for a perfectly valid expression. It was simply that 'NewExpression' was not handled (This is not a problem of course, this is open source community someone else can implement that) but with Errors I would have known right away.
Would you accept a pull request using Error instead of FAIL ?
- Dominant language
- JavaScript
- Stars
- 177
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from browserify/static-eval
-
CVE in word-wrap Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
browserify/static-eval#42 · 1 comment · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
browserify/static-eval#41 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
browserify/static-eval#39 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
browserify/static-eval#38 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
browserify/static-eval#34 · 20 comments · 3 reactions ·
All issues in browserify/static-eval
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·