path.relative ignore backslash

Open
#35 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
javascript

Research direction

Start at the path.relative entry point and inspect how Windows backslash-separated paths are handled. Reproduce the reported failure with a backslash-containing path, then add coverage for the corrected relative-path behavior and run the relevant existing tests.

Written by the indexing model from the issue text.

Description

On windows, path uses backslash instead of forward slash, it will fail to resolve the relative path if given a path with backslash. A simple fix could be to fix the string passed by user with something such as .replace(/\\/g, "/")

Dominant language
JavaScript
Stars
192
Forks
54
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from browserify/path-browserify

All issues in browserify/path-browserify

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.