http browserify broken when sending a full node url object
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- web-dev
Research direction
Start at index.js line 7, where the request URL is assembled from the supplied Node URL object. Reproduce the example with http.get and verify that the generated URL is http://localhost:8081/api/foo?bar=baz, with the port included only once.
Written by the indexing model from the issue text.
Description
var url = {
host: "localhost:8081",
hostname: "localhost",
href: "http://localhost:8081/api/foo?bar=baz",
method: "GET",
path: "/api/foo?bar=baz",
pathname: "/api/foo",
port: "8081",
protocol: "http:",
query: "bar=baz",
search: "?bar=baz",
slashes: true
};
var request = http.get(url, noop);
expected: "http://localhost:8081/api/foo?bar=baz"
actual: "http://localhost:8081:8081/api/foo?bar=baz"
The url that is requested has the port in it 2 times. This is because of this line.
https://github.com/substack/http-browserify/blob/master/index.js#L7
I am finishing up a pull request to fix this where it will try host first, then hostname+port.
Please let me know if you have any input.
- Dominant language
- JavaScript
- Stars
- 245
- Forks
- 104
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from browserify/http-browserify
-
Difficulty 2/5 1-3 hours Newbie friendliness 52/100
browserify/http-browserify#107 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 42/100
browserify/http-browserify#104 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
browserify/http-browserify#102 ·
-
Needs Maintainer Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
browserify/http-browserify#99 · 2 reactions ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 38/100
browserify/http-browserify#96 · 2 comments · 1 reaction ·
All issues in browserify/http-browserify
Similar issues
-
bug customer-eng Durable Agents Inngest status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
githubnext/gh-aw-cao#13475 ·
-
[BUG]: "Clear All" in Settings doesn't clear the saved analysis, old data comes back after reload Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
AOSSIE-Org/OrgExplorer#253 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
oxc-project/oxc#26944 ·
-
ai-observability bug team/ai-observability
Difficulty 2/5 1-3 hours Newbie friendliness 78/100