change to high order component?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 15/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, react
- Domain
- frontend
Research direction
The issue contains a discussion about adding a higher-order component variant for the existing $bind behavior, but names no files, tests, or entry points. Start by locating the current component and render implementation, then determine the intended API and how completion would be verified with the project maintainers.
Written by the indexing model from the issue text.
Description
03:57:54 anon: (me): I think using a function wrapping whole component (+decorator) would feel more natural, at least to me :p
03:58:05 anon: although can be a bit funny syntax wrapping class with function
03:58:16 anon: instead of this.two I mean
03:58:40 (me): anon, yeah, that is more conventional
03:58:58 (me): I forget why I did it this way, so probably no good reason :-)
03:59:11 anon: I guess you wanted to do something with the instance
03:59:31 (me): well it wouldn't be a true high order component because it needs to hijack render
04:00:06 (me): to replace the $bind props with value/onChange or similar
04:00:13 anon: I guess conventional way would be to use hoc and pass $bind as prop
04:00:32 anon: but that would result in some pretty cumbersome syntax
04:01:10 (me): also it needs to be able to access state
04:01:33 (me): though that could be worked around with a little extra code
04:01:37 anon: it could use ref to do that
04:01:54 (me): true
04:03:01 (me): I'll make a note to add a high order component variant
- Dominant language
- JavaScript
- Stars
- 2
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·