brianegan/flutter_architecture_samples

flutter_architecture_samples/firestore_redux/ how can I store the StreamSubscriptions?

Open

#135 opened on May 15, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Dart (8,920 stars) (1,717 forks)batch import
good first issue

Description

Hi Brian, I'm looking for a solution for storing streamsubscriptions in my middleware. How I can store the streamsubscription and cancel them if i need too?

Especially in flutter_architecture_samples/firestore_redux/lib/middleware/store_todos_middleware.dart line 66 / 67 there is a listen() which returns a subscription but it is not stored? How do you cancel the subscription?

In the E-Mail from Nilay couple days ago, there was a suggestion for using streamsubscriptions and canceling them.

http://dart-lang.github.io/linter/lints/cancel_subscriptions.html

class B {
  StreamSubscription _subscriptionB; 
  void init(Stream stream) {
    _subscriptionB = stream.listen((_) {});
  }
  void dispose(filename) {
    _subscriptionB.cancel();
  }
}

And I need in my code the fully control of the subscriptions. I would very appreciate your answer.

Cheers, :)

Contributor guide

Tech stack
dart
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Dart StreamSubscriptionUnderstanding of Redux middleware
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the file `firestore redux/lib/middleware/store todos middleware.dart` around line 66-67 and examine how the subscription is currently used. Consider storing the subscription in the middleware's class and canceling it when the store is disposed. Check the linked lint rule for best practices. Look for any existing patterns in the codebase for managing subscriptions.