brave/brave-browser

Closing a tab from the Tabs Bar will occasionally fail

Open

#48,847 opened on Aug 29, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (16,194 stars) (2,164 forks)batch import
OS/iOSgood first issue

Description

Description

When opening a new tab from a link in an existing tab, the newly opened tab sometimes fails to close when the “X” on the tab bar is pressed. This behavior appears random.

Observed behavior:

  • The “X” button does not close the tab.
  • In some cases, the entire tab bar becomes unresponsive.
  • In other cases, only the single tab fails to close.

Steps to reproduce

  1. Open a tab.
  2. Click a link that opens in a new tab.
  3. Attempt to close the new tab by clicking the “X” in the tab bar.
  4. Observe that the tab occasionally fails to close.

Actual result

https://github.com/user-attachments/assets/1d8e7b43-ec4a-46e1-bf22-e63ba94bfd22

Expected result

Clicking the “X” should always close the selected tab. The Tabs Bar should not lock up.

Reproduces how often

Intermittent issue

Brave version

Version 1.81 (134)

Device/iOS version

iPhone 16 Pro iOS 18.6.2

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

Contributor guide

Tech stack
swiftios
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
iOS developmentSwiftUIKit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the tab bar component in the Brave iOS codebase, likely in TabsBarViewController or similar files. Reproduce the issue by following the provided steps. Check if the issue is related to the tab's close handler or state management. Look for any recent changes to tab handling. Consider adding logging to trace the tab close action.
Closing a tab from the Tabs Bar will occasionally fail · brave/brave-browser#48847 | Good First Issue