brave/brave-browser

Save button doesn't have bottom padding when Developer mode is enabled in Shields settings

Open

#47782 opened on Jul 21, 2025

View on GitHub
 (11 comments) (0 reactions) (1 assignee)JavaScript (16,194 stars) (2,164 forks)batch import
OS/DesktopQA/Yesbugfeature/user-interfacegood first issuepriority/P4release-notes/include

Description

Description

Save button doesn't have bottom padding when Developer mode is enabled in Shields settings

Steps to reproduce

  1. Go to brave://settings/shields/filters
  2. Enable Developer mode
  3. Save changes doesn't have enough bottom padding with the separator line

Actual result

Expected result

Should have enough padding with the separator line

Reproduces how often

Easily reproduced

Brave version (brave://version info)

All

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @rebron @simonhong @brave/legacy_qa

Contributor guide

Tech stack
htmlcssjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSHTML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the CSS for the save button in the shields settings page when developer mode is enabled. Look for the element with class or ID related to 'save' and check the padding bottom property. Ensure it has appropriate spacing from the separator line. The relevant file is likely in the Brave browser UI components directory, possibly under 'brave/components/brave shields' or similar.