brave/brave-browser

The keyboard layout is wrong when defining a shortcut

Open

#47764 opened on Jul 19, 2025

View on GitHub
 (0 comments) (3 reactions) (0 assignees)JavaScript (16,194 stars) (2,164 forks)batch import
OS/DesktopOS/Linuxfeature/keyboard-shortcutshelp wantedpriority/P5

Description

Description

when defining a now shorcut, brave seems to use a querty layout, while my keyboard is azerty

Steps to reproduce

  1. add a new shortcut
  2. tap a key combinaison (example ctrl + a)

Actual result

ctrl + q is shown on the screen

Expected result

ctrl + a should be shown instead

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.80.122 Chromium: 138.0.7204.157 (Build officiel) (64 bits) Révision d9aff5c5def33bd27a6ae282e7b3e90e9bd9cfa2 Système d'exploitation Linux

(flatpak)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Contributor guide

Tech stack
javascriptcpp
Domain
frontendlocalization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptfamiliarity with keyboard events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the shortcut definition UI in Brave's frontend code, likely in files under `app/` or `components/` that handle keyboard event capturing. Look for where key events are mapped to display strings. The issue is that the current implementation assumes QWERTY layout. Test with AZERTY layout on Linux. Consider using `event.code` vs `event.key`; the former is layout independent. A fix might involve using `event.code` for display or detecting the keyboard layout. Check existing Chromium issues for similar bugs.