brave/brave-browser

Add keyboard shortcut to update adblock lists

Open

#43667 opened on Jan 31, 2025

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (16,194 stars) (2,164 forks)batch import
OS/DesktopQA/Yesenhancementfeature/keyboard-shortcutsfeature/shields/adblockgood first issuepriority/P4release-notes/include

Description

Requested at https://x.com/jarkk0sal0/status/1885404217864528039?s=46&t=c88ZoLNNPThnGggE75IoLQ

We don't need to assign a shortcut by default, but having it available for configuration in brave://settings/system/shortcuts could be useful.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Chromium's shortcut systemFamiliarity with Brave's settings UI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine how existing keyboard shortcuts are defined in Brave's settings, likely in files under `brave/settings/` or `chrome/browser/ui/webui/settings/`. The shortcut configuration file (e.g., `shortcuts mapping.js`) and the settings page for shortcuts (`shortcuts.html`) are key. Look at the tweet referenced for additional context. No existing PR or assignee, so the issue is open for implementation.