brave/brave-browser

Shortcut in the commander show incorrect key binding order instead of the originally created order

Open

#43129 opened on Jan 6, 2025

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (16,194 stars) (2,164 forks)batch import
OS/DesktopQA/Test-Plan-SpecifiedQA/Yesfeature/keyboard-shortcutsgood first issuepolishpriority/P5

Description

Description

Found while testing https://github.com/brave/brave-browser/issues/41412. Created shortcut key binding Ctrl + Shift + E in brave://settings/system/shortcuts for Export all bookmarks. However, this key binding order in commander is not same and it's shown as Shift + Ctrl + E. But both key bindings work to export bookmarks.

Steps to reproduce

  1. Install 1.75.145
  2. launch Brave
  3. opened brave://settings/system/shortcuts
  4. created a key binding Ctrl + Shift + E
  5. opened a new tab and pressed Ctrl + Spacebar or hamburger menu >>Quick commands
  6. type Export all bookmarks

Actual result

Shift + Ctrl + E is shown

example example
Image

Expected result

correct order should be shown i.e. Ctrl + Shift + E

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.75.145 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
-- | --
Revision | 4ecdecd1626892f9f317e9d8154c50cf8459d3bf
OS | Windows 11 Version 24H2 (Build 26100.2605)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@fallaciousreasoning @rebron

Contributor guide