brave/brave-browser

Custom Scriptlets / Developer mode should have buttons to re-order the list of Scriptlets

Open

#43,106 opened on Jan 5, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (16,194 stars) (2,164 forks)batch import
OS/Desktopfeature-requestfeature/dev-toolsfeature/shields/adblock/custom-scriptletsgood first issuepriority/P5

Description

Platforms

all

Description

Currently, when you add a custom Scriptlets, they will be saved in the order when they get added.

It would be nice to be able to re-order the list when the list of Scriptlets gets larger, to accomodate the human logic and brain, because sometimes you add a Scriptlet, but in the future you might add more scriptlets targeting specific priorities or domains or types, so just being able to move them around without having to take the time and manually cut and paste the Scriptlets to re-arrange them, should be good.

Since the Custom Scriptlets were implemented with LevelDB, that means it is not possible to open the DB in an easy to use 3rd party program, and edit it to easily move things around, like a JSON or SQLite DB would be.

Contributor guide

Tech stack
javascript
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptLevelDB basicsReact (likely)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the existing custom scriptlets UI implementation in brave browser, likely in the settings or developer tools area. Locate the component that renders the list of scriptlets and the LevelDB read/write logic. Check for existing sort or drag and drop functionality. Consider adding reordering buttons (move up/down) to each scriptlet item, and update the order in LevelDB accordingly. Look at files like `adblock` or `custom scriptlets` in the source tree.