brave/brave-browser

Incorrect icon for Bookmarks in side panel

Open

#42,163 opened on Nov 7, 2024

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (16,194 stars) (2,164 forks)batch import
OS/Desktopgood first issuemisc/iconspolishpriority/P5

Description

Description

The bookmarks icon in the side panel is incorrect.

Steps to reproduce

  1. Open the bookmarks side panel
  2. Notice the bookmarks icon. The sizing is incorrect.

Actual result

In 1.74.1

Image

In 1.73.x Image

Expected result

[placeholder]

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.74.1

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Contributor guide

Tech stack
csshtmljavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic CSSfamiliarity with Brave browser UI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the side panel implementation in Brave's Chromium based UI. Look for the bookmarks icon component, likely styled with CSS. Compare the icon sizing between versions to identify the CSS property causing the discrepancy. Check recent commits related to side panel or bookmarks icon for any regressions.