brave/brave-browser

Show BAT favicon when adding rewards internal page to sidebar

Open

#41617 opened on Oct 14, 2024

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (16,194 stars) (2,164 forks)batch import
OS/Desktopfeature/settingsfeature/sidebargood first issuepriority/P5

Description

When adding the rewards internal page to the sidebar, the icon doesn't appear and instead shows an "R". We should change the icon that shows so it shows the correct BAT icon

Figma https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=8165-19398&t=5wWBqB0CO1rtctLm-1

Actual result

Image

Expected result

Image

Contributor guide

Tech stack
javascriptcssreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic React knowledgefamiliarity with Brave UI components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review the Brave sidebar code for adding internal pages. The icon for the rewards page is currently a placeholder 'R'. The Figma design (linked) shows the correct BAT icon. Locate where the sidebar item icon is set and replace it with the appropriate BAT icon asset. Check existing icon assets in the repository for the BAT icon.