brave/brave-browser

Clicking on `Filter lists` opens up the filter page in a new tab even though the filter page already opened in another tab

Open

#24120 opened on Jul 19, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (16,194 stars) (2,164 forks)batch import
OS/DesktopQA/Test-Plan-SpecifiedQA/Yesgood first issuepriority/P4suggestion

Description

Description

Found while testing https://github.com/brave/brave-browser/issues/23285 Clicking on Filter lists opens up the filter page in a new tab even though the filter page already opened in another tab

Steps to Reproduce

  1. Clean profile 1.41.x or 1.42.x
  2. Open any site
  3. Click on shield and expand the advanced view and click on Filter lists multiple times
  4. Clicking on Filter lists opens up the filter page in a new tab even though the filter page already opened in another tab

Actual result:

Clicking on Filter lists opens up the filter page in a new tab even though the filter page already opened in another tab

Expected result:

Clicking on Filter lists should redirect to the existing filter page if it's already opened in another tab

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.42.68 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @petemill @nullhook @rebron @brave/legacy_qa

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptReactBrave browser development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the click handler for the 'Filter lists' button in the shields panel. Look for existing logic that opens new tabs for internal pages (e.g., using `chrome.tabs.create` or similar). Check if there is a mechanism to check for an already open tab with the same URL, such as querying all tabs. The fix should ensure that clicking 'Filter lists' focuses the existing tab instead of opening a new one. Reference the linked issue #23285 for additional context on the expected behavior.