brave/brave-browser

[Desktop] Allow users to add site exceptions for data that is cleared "on exit"

Open

#10493 opened on Jun 26, 2020

View on GitHub
 (64 comments) (72 reactions) (1 assignee)JavaScript (16,194 stars) (2,164 forks)batch import
OS/AndroidOS/Desktopcontributordesignenhancementfeature/global-settingsfeature/settingsgood first issueneeds-discussionpriority/P4

Description

Description

As it is now, any data type that is checked in the Clear browsing data --> [On exit] will have all data of that type removed upon closing the browser. While this is the intended function, we should implement a function similar to what Microsoft Edge does, where site exceptions can be added to a "Do not clear" list. Data on this list is ignored when the browser runs "clear on exit":

image

This would help users maintain login data for sites they regularly visit and not have to re-authenticate every time data is erased. Additionally, this helps with support, since clearing browsing data often resolves issues with bad cache data -- having the ability to suggest users do this, but without sacrificing specific data they know they want would be very useful and appreciated by users

Miscellaneous Information:

Original thread that bought this to my attention (again): https://community.brave.com/t/delete-all-cookies-on-exit-except-allowed-list/137872/5

Contributor guide

Tech stack
javascripttypescriptreactcpp
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Chromium data clearing architectureC++ developmentReact UI componentsBrave browser build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
This issue requires implementing a site exception list for the 'clear on exit' feature. Start by examining the existing ClearBrowsingDataOnExit implementation in Brave's settings code (likely in components/brave ads or browser/brave profile). Refer to Microsoft Edge's similar feature as a design reference. The community thread linked in the issue provides user requirements. Look for existing UI components for managing site exceptions in Brave's password or cookie settings to reuse patterns.