Improvement: Use declarativeContent to do domain matching
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- tooling
Research direction
Compare the current URL/domain matching implementation with the linked pageaction_by_url background.js example and the declarativeContent documentation. Confirm how the extension currently performs matching, then verify that declarativeContent handles the same domain and URL cases when the work is complete.
Written by the indexing model from the issue text.
Description
Older versions of the pageaction_by_url sample used simple .indexOf matching to see whether a domain/URL matches or not. This plugin basically does the same.
Newer versions of the pageaction_by_url sample however seem to use something named declarativeContent for its URL matching.
- Dominant language
- JavaScript
- Stars
- 4
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bramus/github-toggle-chrome-extension
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
All issues in bramus/github-toggle-chrome-extension
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·