brailcom/speechd

user configuration errors should be papered over

Open

#883 opened on Mar 17, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (86 forks)auto 404
buggood first issuehelp wantedpriority

Repository metrics

Stars
 (325 stars)
PR merge metrics
 (PR metrics pending)

Description

Reported by @albertotirla

Steps to reproduce

Not sure how, just reporting here what was said on matrix.

Obtained behavior

“when the tinyest thing is wrong in sd's configuration, it doesn't just remove that module with a warning, fallback to defaults, any of that, but instead it entirely crashes, leaving the user with absolutely no speech”

Expected behavior

spd should always at least produce speech, whatever configuration error the user may have done.

Of course, it the user directed speech to an audio card whose headphones are not connected, spd can't do much, but there are probably various situations where spd detects an error, and should be able to fallback on something that works.

Contributor guide

Research direction
Identify all code paths where configuration errors cause crashes and implement graceful fallbacks (e.g., default settings) instead of exiting.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Cdebugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40