Investigate memory management issue with HttpRequest URLs in http_client.zig
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- zig
- Domain
- testing
Research direction
Start with http_client.zig and trace HttpRequest URL ownership through initialization and deinit, then inspect the referenced test setup. Determine how global strings are handled and whether the existing duplication workaround is still needed. Done means request cleanup no longer attempts to free non-owned global strings and the affected tests pass.
Written by the indexing model from the issue text.
Description
Review and refactor how memory is managed for HttpRequest URLs, particularly in test scenarios where the deinit method tries to free global strings. Consider alternative approaches for test setups or memory management.
Reference:
// TODO: The request de-allocates the memory used by the url in the deinit method.
// Because of this, with this test, we have to dupe it or else it cant deinit a global string.
// Needing to do this is a sign that something is off here, but also newing up requests directly
// isn't really intended either. Either way, need to look into this further.
- Dominant language
- Zig
- Stars
- 11
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bradcypert/httpspec
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
bradcypert/httpspec#22 · 1 comment ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 45/100
bradcypert/httpspec#12 ·
All issues in bradcypert/httpspec
Similar issues
-
agent/security hive/hosted-available-lke648397-260827-5n31 security
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
jbaruch/coding-policy#497 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
test-change-proposal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
web-platform-tests/interop#1455 ·
-
.NET Flaky Test Testing Tests
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
getsentry/sentry-dotnet#5617 · 1 comment ·