bpmn-io/bpmn-js

A bug occurs when deleting a box ：A DOM element reference is required, But there is no problem using shift to select

Open

#2,221 opened on Aug 19, 2024

View on GitHub
 (11 comments) (0 reactions) (0 assignees)JavaScript (7,739 stars) (1,249 forks)batch import
backlogbuggood first issuespring cleaning

Description

Describe the Bug

I don't know if this is a feature: shift+left mouse button to select the element dragged into the canvas, and then use the shortcut key del to delete, a bug will appear: console.ts:40 unhandled error in event listener Error: A DOM element reference is required, But there is no problem using shift to select

Steps to Reproduce

Shift+left mouse button selects the elements dragged into the canvas, and then uses the shortcut key del to delete shift+left mouse button to select the elements dragged into the canvas, and then uses the shortcut key del to delete

The following cases occurred in：https://demo.bpmn.io/s/start

https://github.com/user-attachments/assets/3b263e7e-f539-4618-9e6a-990f23684291

Expected Behavior

Delete the node selected by the box

Environment

  • Browser: [Chrome 127.0.6533.120]
  • OS: [e.g. Windows 11]

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScript knowledgeFamiliarity with DOM events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the selection handling and keyboard event listeners in the bpmn js source code. The error 'A DOM element reference is required' suggests that during deletion after shift+click selection, a DOM element reference is missing. Look into the BoxSelection behavior and the delete key handler. Check if the selected elements are properly referenced when deletion is triggered. Relevant files might include selection/Selection.js, features/box selection/, and keyboard/KeyboardBindings.js.
A bug occurs when deleting a box ：A DOM element reference is required, But there is no problem using shift to select · bpmn-io/bpmn-js#2221 | Good First Issue