bpmn-io/bpmn-js

BPMNLabel is not removed when name is erased on an external label element

Open

#1,893 opened on Apr 19, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (7,739 stars) (1,249 forks)batch import
backlogbuggood first issuespring cleaning

Description

One more bug related to this: We don't remove BPMNLabel when name is erased via modeling.updateProperties in external label elements.

Originally posted by @barmac in https://github.com/bpmn-io/bpmn-js/issues/1872#issuecomment-1511101056

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript programmingBPMN modeling conceptsbpmn js codebase familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate how BPMNLabel is handled when the name is erased on external label elements. Look at the modeling.updateProperties function in the bpmn js source code, specifically in the BpmnLabelSupport or related modules. The fix should ensure that when the name property is set to empty, the corresponding BPMNLabel element is removed. Review the test suite for similar label removal behavior to ensure consistency.
BPMNLabel is not removed when name is erased on an external label element · bpmn-io/bpmn-js#1893 | Good First Issue