bpmn-io/bpmn-js

BPMNLabel is not removed when name is erased on an external label element

Open

#1,893 opened on Apr 19, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,249 forks)batch import
backlogbuggood first issuespring cleaning

Repository metrics

Stars
 (7,739 stars)
PR merge metrics
 (Avg merge 4h 59m) (9 merged PRs in 30d)

Description

One more bug related to this: We don't remove BPMNLabel when name is erased via modeling.updateProperties in external label elements.

Originally posted by @barmac in https://github.com/bpmn-io/bpmn-js/issues/1872#issuecomment-1511101056

Contributor guide

Research direction
Investigate how external label elements handle name changes in bpmn js, particularly the updateProperties method and the removal of BPMNLabel.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45