bp/resqpy

Enable a progressively larger subset of ruff rules for logical issues

Open

#924 opened on Jun 19, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (18 forks)auto 404
good first issue

Repository metrics

Stars
 (66 stars)
PR merge metrics
 (PR metrics pending)

Description

We could enable some linting rules for things that look like real bugs. A few high signal-to-noise ones could be:

  • PLW0177 - we have a few checks with == np.nan that always evaluate to False and are thus pointless
  • B006 - mutable default args, easy to fix
  • B904 - better exception chaining
  • PLW2910 - loop var overwritten, a bit suspicious, 10 hits

Others to investigate: PLE / RSE, FLY, PIE810.

Other rules which probably make sense only after enabling ruff format, but which are probably lower-priority:

  • UP (pyupgrade), urles are largely auto-fixable (hurrah)
  • SIM (simplify) - often useful
  • RET - avoid returning None implicitly. Perhaps a longer-term goal, as lots of resqpy functions

Contributor guide

Research direction
Pick one of the listed ruff rules (e.g., B006 for mutable default arguments) and fix the instances in the codebase. Ensure you have ruff installed and run 'ruff check' to see the warnings. For each rule, you may need to make minimal changes to address the issue while maintaining code functionality.
Tech stack
python
Domain
backenddeveloper experience
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80