boyan01/overlay_support

Should showOverlay() parameter builder be pass Animation instead of progress ?

Open

#28 opened on Dec 9, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Dart (103 forks)github user discovery
help wanted

Repository metrics

Stars
 (379 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Now:

typedef Widget AnimatedOverlayWidgetBuilder(BuildContext context, double progress);

Should be:

typedef Widget AnimatedOverlayWidgetBuilder(BuildContext context, Animation<double> animation);

Contributor guide

Research direction
Update the typedef 'AnimatedOverlayWidgetBuilder' to use Animation<double> instead of double progress, then update the implementation of showOverlay() to pass the animation object.
Tech stack
dartflutter
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DartFlutterGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90