misalignment between code and doc

Open
#15 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
angular, aws, javascript, node.js

Research direction

Compare the AWS Cognito documentation with box-node-cognito-lambdas-sample/tokenExchange/box-manager.js and box-aws-cognito-angular2-skeleton-app-sample/src/app/config/box/box.config.ts. First inspect the referenced code and the corresponding documentation, then make the environment-variable and custom-attribute names consistent across both examples. Done means the docs and sample code use matching names.

Written by the indexing model from the issue text.

Description

Hi,

The first issue is

For the AWS Cognito examples using lambda, it is said in doc to use the following env variable:
BOX_PRIVATE_KEY_PASSPHRASE = <YOUR_APP_PRIVATE_KEY_PASSPHRASE>

but the lambda code is using BOX_PRIVATE_KEY_PASSWORD (see https://github.com/box/samples/blob/cognito_integration/box-node-cognito-lambdas-sample/tokenExchange/box-manager.js#L16)

The second issue is with the angular2 application

Its mentioned to add a custom attribute called custom:box_appuser_id which will store the box id for the given account.

but the application is using box_appuser_token (see https://github.com/box/samples/blob/master/box-aws-cognito-angular2-skeleton-app-sample/src/app/config/box/box.config.ts#L10)

Dominant language
JavaScript
Stars
71
Forks
83
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from box/samples

All issues in box/samples

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.