Log failed Preflight check at INFO level

Open
#527 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
api

Research direction

Start by locating the Preflight implementation and the warning log in the Python SDK. Review any existing tests for failed Preflight checks, then verify that a 409 response is still returned while the corresponding log entry uses INFO rather than WARNING.

Written by the indexing model from the issue text.

Description

enhancement
Is your feature request related to a problem? Please describe.

I don't think the preflight check, which throws a 409 when a file exists, should be logging a WARNING in the logs.

Describe the solution you'd like

I think Preflight in particular should log with INFO level. Although I can understand the decision for Preflight to throw a 409, in this case I am calling it specifically to ask "can I overwrite this file?" So the response, whatever it is, shouldn't be a WARNING for my application.

Put another way: If the Preflight just throws a 409 and logs a warning, I don't see how that is different to simply calling folder.upload() and letting it throw the exception. Aren't I just wasting an API call?

Describe alternatives you've considered

I really don't want to set the SDK log level to ERROR and above, but that is the only option I think?

Dominant language
Python
Stars
460
Forks
223
Avg merge
14h 18m
Merged PRs (30d)
21

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from box/box-python-sdk

All issues in box/box-python-sdk

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.