bottlerocket-os/twoliter

Remove systemd-networkd from Manifest

Open

#142 opened on Jan 26, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (43 forks)auto 404
good first issue

Repository metrics

Stars
 (34 stars)
PR merge metrics
 (PR metrics pending)

Description

Once https://github.com/bottlerocket-os/bottlerocket/pull/3700 lands, there will no longer be a need for this field

https://github.com/bottlerocket-os/twoliter/blob/40e21e03aecc18de092f9cd94bb045e6c3028d8d/tools/buildsys/src/manifest.rs#L536 https://github.com/bottlerocket-os/twoliter/blob/40e21e03aecc18de092f9cd94bb045e6c3028d8d/tools/buildsys/src/manifest.rs#L201

          Can you open an issue in twoliter to remove this feature flag if we're not using it? We should cut it from `buildsys` and `Dockerfile`.

Originally posted by @bcressey in https://github.com/bottlerocket-os/bottlerocket/pull/3700#discussion_r1449605953

Contributor guide

Research direction
Examine the referenced lines in buildsys/src/manifest.rs to understand the field and feature flag usage, then remove them from the manifest code and any related Dockerfile or config files. Ensure no other parts of the codebase depend on it.
Tech stack
rust
Domain
build systemdevops
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60