borgbackup/borg

freebsd 14 test failure in test_multiple_link_exclusion

Open

#8740 opened on Apr 10, 2025

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (10,086 stars) (732 forks)batch import
help wantedos: bsdos: other

Description

    freebsd14: ______________ DiffArchiverTestCase.test_multiple_link_exclusion _______________
    freebsd14: [gw12] freebsd14 -- Python 3.10.16 /vagrant/borg/borg/.tox/py310-fuse2/bin/python
    freebsd14: 
    freebsd14: self = <borg.testsuite.archiver.DiffArchiverTestCase testMethod=test_multiple_link_exclusion>
    freebsd14: 
    freebsd14:     @requires_hardlinks
    freebsd14:     def test_multiple_link_exclusion(self):
    freebsd14:         path_a = os.path.join(self.input_path, 'a')
    freebsd14:         path_b = os.path.join(self.input_path, 'b')
    freebsd14:         os.mkdir(path_a)
    freebsd14:         os.mkdir(path_b)
    freebsd14:         hl_a = os.path.join(path_a, 'hardlink')
    freebsd14:         hl_b = os.path.join(path_b, 'hardlink')
    freebsd14:         self.create_regular_file(hl_a, contents=b'123456')
    freebsd14:         os.link(hl_a, hl_b)
    freebsd14:         self.cmd('init', '--encryption=repokey', self.repository_location)
    freebsd14:         self.cmd('create', self.repository_location + '::test0', 'input')
    freebsd14:         os.unlink(hl_a)  # Don't duplicate warning message- one is enough.
    freebsd14:         self.cmd('create', self.repository_location + '::test1', 'input')
    freebsd14: 
    freebsd14: >       output = self.cmd('diff', '--pattern=+ fm:input/b', '--pattern=! **/', self.repository_location + '::test0', 'test1', exit_code=EXIT_WARNING)
    freebsd14: 
    freebsd14: .tox/py310-fuse2/lib/python3.10/site-packages/borg/testsuite/archiver.py:4858:
    freebsd14: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
    freebsd14: .tox/py310-fuse2/lib/python3.10/site-packages/borg/testsuite/archiver.py:295: in cmd
    freebsd14:     self.assert_equal(ret, exit_code)
    freebsd14: E   AssertionError: 0 != 1
    freebsd14: ----------------------------- Captured stdout call -----------------------------
    freebsd14: [ctime: Thu, 2025-04-10 17:04:11 -> Thu, 2025-04-10 17:04:15] input/b/hardlink
    freebsd14:

Contributor guide

Tech stack
python
Domain
testingbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonBorg basicstesting with pytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the test failure on FreeBSD 14 where `test multiple link exclusion` expects exit code 1 (EXIT WARNING) but gets 0. Review the diff command logic in `borg/archiver.py` and the test setup in `borg/testsuite/archiver.py`. Check if the pattern matching changes behavior for hardlinks or if FreeBSD's filesystem differences affect the outcome. Look at the comments in the issue for any clues or reproduction steps.