borgbackup/borg

xattr and ACL support for Solaris 11 and OpenIndiana

Open

#1337 opened on Jul 14, 2016

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Python (10,086 stars) (732 forks)batch import
enhancementfilesystemhelp wantedos: other

Description

xattrs: Solaris 11 and OpenIndiana have the same API (O_XATTR):

Note that xattr/fsattr in sunos5 is far more powerful than on the other platforms. On sunos5 they are essentially file system namespace attached to every file. You can put any file type in there (e.g. sockets, block devices, link) and have arbitrarily complex directory structures. So it may make sense to map these into normal items (NUL as separator? - other platforms would not extract) and traverse them. Or, we could flatten them and only regard regular files (i.e. key-value pairs).

ACLs: APIs are also similar to each other (and our already implemented APIs)

Contributor guide

Tech stack
python
Domain
backendsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Python programmingKnowledge of filesystem xattr/ACLFamiliarity with Borg's platform code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Examine Borg's platform specific code for xattr and ACL support in `src/borg/platform/`. Study the Solaris and Illumos man pages for O XATTR and acl APIs. Determine how to map the Solaris xattr namespace (which can contain any file type) into Borg's existing key value model. Consider the tradeoff between flattening and preserving directory structure. Look for any existing tests for other platforms to understand expected behavior.