boot-clj/boot

Consider Reader Support For File Objects

Open

#250 opened on Jul 13, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Clojure (1,748 stars) (178 forks)batch import
Enhancementhelp wanted

Description

were it not for the File object on :dir in the TmpFile record, tmpfiles could be passed directly into pods.

#boot.tmpdir.TmpFile{:dir #object[java.io.File 0x5577160d[/Users/me/.boot/cache/tmp/Users/me/Development/apps/myapp/joo/7o2s6s], :path "js/myscript.js", :id "fe1bd08f4351c143197a11cf777ef047", :time 1436124119000}

storing the directory as a string instead makes this possible:

(defn marshall-tmpfile [tmpfile] (update tmpfile :dir #(.getPath %)))

#boot.tmpdir.TmpFile{:dir "/Users/me/.boot/cache/tmp/Users/me/Development/apps/myapp/joo/7o2s6s", :path "js/myscript.js", :id "fe1bd08f4351c143197a11cf777ef047", :time 1436124119000}

it would be an improvement, for my case, to store the TmpFile :dir as a string instead of a File, or perhaps more generally, add reader support for File types to the pod machinery.

Contributor guide

Tech stack
None
Domain
build system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
ClojureBoot build tool
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
The issue proposes changing the :dir field in TmpFile from a File object to a string. Research the TmpFile record definition in the boot source code, particularly the pod machinery that handles file serialization. Determine if a simple type change is backward compatible or if reader support for File types is needed. Look at the only comment in the issue for any additional context.