Reproducible builds ruin time_conversion_helper
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- backend, build-system
Research direction
Start with include/boost/wave/util/time_conversion_helper.hpp around line 127 and reproduce the failure under Bazel's sandboxed, reproducible build settings. Trace how replacement date macros reach time_conversion_helper and determine the expected behavior when those macros are unavailable. Done means the runtime assertion no longer breaks supported reproducible builds, with coverage for the affected configuration.
Written by the indexing model from the issue text.
Description
I use bazel as my build system, and bazel specializes in reproducible builds, which basically means it tries to build everything in a sandbox with limited access to system libraries, and replaces the various date macros with some string like REDACTED . This breaks the time_conversion_helper and asserts(false) at runtime.
not sure what the best solution is, but it would be great if there was a macro that made the time-based macros optional.
My solution is to fork boost and comment out the assertion (https://github.com/boostorg/wave/blob/99ccc6e3cbd3fa347dc23f10518aa7d33d31573e/include/boost/wave/util/time_conversion_helper.hpp#L127).
- Dominant language
- C++
- Stars
- 29
- Forks
- 55
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boostorg/wave
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Is it possible? Dumping preprocessor state at end of output so that preprocessing can be resumed? Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·