operators_test invokes undefined behavior in random input tests

Open
#77 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
testing-qa

Research direction

Start with the random input tests in test/operators_test.cpp, especially lines 619-641, and run the test suite with UBSAN enabled. Determine which shifts and arithmetic operations trigger undefined behavior and preserve the intended test coverage while making the tests valid. Done means UBSAN no longer reports these tests and operators_test still passes.

Written by the indexing model from the issue text.

Description

The random input tests of operators_test.cpp invokes undefined behavior such as shifting integers for more than the left operand capacity or signed integer overflows in arithmetic tests. These issues are flagged by UBSAN.

Currently, I have disabled these tests under UBSAN as a workaround to keep UBSAN otherwise enabled. However, the tests as they are are invalid. I'm not sure of the purpose of this series of tests and whether the random input is essential in some regard, so I decided to not remove the tests straight away. But the tests need to be corrected.

CC: @d-frey

Dominant language
C++
Stars
51
Forks
71
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/utility

All issues in boostorg/utility

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.