GCC suggest-override warnings
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start with the warning locations in boost/thread/detail/nullary_function.hpp, boost/thread/detail/thread.hpp, boost/thread/future.hpp, libs/thread/src/future.cpp, and libs/thread/src/pthread/thread.cpp. Review the BOOST_OVERRIDE introduction in the linked Boost.Config commit and reproduce the Boost 1.72 GCC 7.5 build with -Wsuggest-override. Done means the reported warnings are addressed without new build failures.
Written by the indexing model from the issue text.
Description
Complete list of warnings when Boost 1.72 is built with GCC 7.5 with -Wsuggest-override added to cxxflags. Duplicated warnings from same location are omitted:
./boost/thread/detail/nullary_function.hpp:158:11: warning: ‘R boost::detail::nullary_function::impl_type::call() [with F = boost::thread_detail::default_barrier_reseter; R = long unsigned int]’ can be marked override [-Wsuggest-override] ./boost/thread/detail/nullary_function.hpp:62:14: warning: ‘virtual void boost::detail::nullary_function::impl_type_ptr::call()’ can be marked override [-Wsuggest-override] ./boost/thread/detail/thread.hpp:118:18: warning: ‘void boost::detail::thread_data::run() [with F = boost::_bi::bind_t, boost::log::v2_mt_posix::sinks::unbounded_fifo_queue> >, boost::_bi::list1, boost::log::v2_mt_posix::sinks::unbounded_fifo_queue>*> > >]’ can be marked override [-Wsuggest-override] ./boost/thread/detail/thread.hpp:804:18: warning: ‘void boost::detail::thread_exit_function::operator()() [with F = boost::_bi::bind_t, boost::_bi::list1 > >]’ can be marked override [-Wsuggest-override] ./boost/thread/future.hpp:319:18: warning: ‘virtual void boost::detail::shared_state::do_continuation(boost::unique_lock&)’ can be marked override [-Wsuggest-override] ./boost/thread/future.hpp:3465:18: warning: ‘virtual void boost::detail::task_shared_state::do_apply()’ can be marked override [-Wsuggest-override] ./boost/thread/future.hpp:3486:18: warning: ‘virtual void boost::detail::task_shared_state::do_run()’ can be marked override [-Wsuggest-override] ./boost/thread/future.hpp:947:24: warning: ‘void boost::detail::future_async_shared_state_base::wait(boost::unique_lock&, bool) [with Rp = void]’ can be marked override [-Wsuggest-override]
libs/thread/src/future.cpp:23:29: warning: ‘virtual const char* boost::thread_detail::future_error_category::name() const’ can be marked override [-Wsuggest-override] libs/thread/src/future.cpp:24:29: warning: ‘virtual std::__cxx11::string boost::thread_detail::future_error_category::message(int) const’ can be marked override [-Wsuggest-override] libs/thread/src/pthread/thread.cpp:225:18: warning: ‘virtual void boost::detail::externally_launched_thread::run()’ can be marked override [-Wsuggest-override] libs/thread/src/pthread/thread.cpp:227:18: warning: ‘virtual void boost::detail::externally_launched_thread::notify_all_at_thread_exit(boost::condition_variable*, boost::mutex*)’ can be marked override [-Wsuggest-override]
BOOST_OVERRIDE was introduced in https://github.com/boostorg/config/commit/ffe4e0f5a448578cce14e3eed0cf7163333a81d9.
- Dominant language
- C++
- Stars
- 213
- Forks
- 171
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boostorg/thread
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Difficulty 3/5 1-2 days Newbie friendliness 64/100
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100