Spectre mitigation warning on progress_monitor code

Open
#427 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
testing-qa

Research direction

Inspect include/boost/test/impl/progress_monitor.ipp around line 61, then reproduce the warning with MSVC 143 in Boost.Test header-only mode using "included". Check whether the variable modification in the condition is related to C5045; done means the warning's cause and an appropriate correction or confirmation are established.

Written by the indexing model from the issue text.

Description

I am using Boost.Test (in header-only mode, using "included"), for a Boost-aspiring project https://github.com/correaa/boost-multi

I am getting this warning with MSVC 143:

D:\a\boost-multi\boost-multi\vcpkg\installed\x64-windows\include\boost\test\impl\progress_monitor.ipp(62): warning C5045: Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified [D:\a\boost-multi\boost-

https://github.com/correaa/boost-multi/actions/runs/10066511703/job/27828050365#step:9:62

FWIIW, this line has suspicious code as a variable is modified inside a condition: https://github.com/boostorg/test/blob/develop/include/boost/test/impl/progress_monitor.ipp#L61

Dominant language
C++
Stars
213
Forks
149
Avg merge
18h 17m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/test

All issues in boostorg/test

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.