boost/sort/block_indirect_sort/block_indirect_sort.hpp doesn't compile under VS2017

Open
#60 8 comments 0 reactions 1 assignee View on GitHub

@fjtapia is already working on this.

Since Jan 29, 2023.

Assessment

This issue has not been assessed yet.

Description

Including #include "boost/sort/block_indirect_sort/block_indirect_sort.hpp" and using boost::sort::block_indirect_sort doesn't compile on VS2017 (C++17 compiler). There are following errors:

1>c:\views\conan\BoostHeaders\3.0.0+1.75.0\rs3\stable\package\5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9\include\boost/sort/common/spinlock.hpp(72): error C2065: 'not': undeclared identifier
1>c:\views\conan\BoostHeaders\3.0.0+1.75.0\rs3\stable\package\5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9\include\boost/sort/common/spinlock.hpp(72): error C2146: syntax error: missing ';' before identifier 'af'

Furthermore including: #include <boost/range/algorithm.hpp> along causes more errors since boost::sort is now template method and also internal namespace name used by block_indirect_sort.hpp header.

This is in boost 1.75.0, but I don't see it fixed in current version either (by brief look).

Dominant language
C++
Stars
58
Forks
47
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/sort

All issues in boostorg/sort

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.