Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Indexing operator of iterator_range<counting_iterator<...>> produces undefined behavior

Open
#83 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
backend

Research direction

Start by compiling the reproducer from test_counting_iterator_range_indexing.cpp and inspect boost/range/iterator_range_core.hpp around iterator_range_base::operator[]. Confirm the warning and dangling-reference behavior for counting_iterator, then add a regression test showing that range[0] produces 0 without undefined behavior.

Written by the indexing model from the issue text.

Description

Example:

#include <boost/iterator/counting_iterator.hpp>
#include <boost/range/iterator_range.hpp>

#include <iostream>
#include <type_traits>

int main(int, char **)
{
    using iterator = boost::counting_iterator<int>;
    using iterator_range = boost::iterator_range<iterator>;

    iterator first(0), last(3);
    iterator_range range(first, last);

    std::cout << "iterator::reference is a reference type: " << std::is_reference<iterator::reference>::value << std::endl;
    std::cout << "iterator_range::reference is a reference type: " << std::is_reference<iterator_range::reference>::value << std::endl;

    std::cout << "first[0] returns a reference type: " << std::is_reference<decltype(first[0])>::value << std::endl;
    std::cout << "range[0] returns a reference type: " << std::is_reference<decltype(range[0])>::value << std::endl;
    
    std::cout << "first[0] == " << first[0] << std::endl;
    std::cout << "range[0] == " << range[0] << std::endl; // <-- segfault
}

Output:

iterator::reference is a reference type: 1
iterator_range::reference is a reference type: 1
first[0] returns a reference type: 0
range[0] returns a reference type: 1
first[0] == 0
Segmentation fault (core dumped)

Expected behavior: range[0] returns 0.

If Boost headers are copied to ./boost and the program is compiled with g++ -I. option, the compiler produces the following warning:

In file included from ./boost/range/iterator_range.hpp:13,
                 from test_counting_iterator_range_indexing.cpp:2:
./boost/range/iterator_range_core.hpp: In instantiation of ‘boost::iterator_range_detail::iterator_range_base<IteratorT, boost::iterators::random_access_traversal_tag>::reference boost::iterator_range_detail::iterator_range_base<IteratorT, boost::iterators::random_access_traversal_tag>::operator[](boost::iterator_range_detail::iterator_range_base<IteratorT, boost::iterators::random_access_traversal_tag>::difference_type) const [with IteratorT = boost::iterators::counting_iterator<int>; boost::iterator_range_detail::iterator_range_base<IteratorT, boost::iterators::random_access_traversal_tag>::reference = const int&; boost::iterator_range_detail::iterator_range_base<IteratorT, boost::iterators::random_access_traversal_tag>::difference_type = long int]’:
test_counting_iterator_range_indexing.cpp:23:43:   required from here
./boost/range/iterator_range_core.hpp:391:32: warning: returning reference to temporary [-Wreturn-local-addr]
         return this->m_Begin[at];
                                ^

The reason for the segmentation fault is that iterator_range::operator[] returns a reference to a stack-allocated object returned by counting_iterator::operator[].

Dominant language
C++
Stars
45
Forks
104
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/range

All issues in boostorg/range

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.