NetBSD Build Errors

Open
#416 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp

Research direction

Start by reviewing libs/filesystem/src/directory.cpp around line 273 and src/posix/close_handles.cpp around line 188, then reproduce the reported build on NetBSD. Investigate the dirfd compilation errors and verify that Boost Process builds successfully after the related pull request is considered.

Written by the indexing model from the issue text.

Description

Got someone else online to test boost process for me on their NetBSD machine and these are the errors they got:

In file included from ../../../../libs/filesystem/src/directory.cpp:38:
../../../../libs/filesystem/src/directory.cpp: In function ‘int boost::filesystem::detail::{anonymous}::dir_itr_fd(const boost::filesystem::detail::dir_itr_imp&, boost::system::error_code&)’:
../../../../libs/filesystem/src/directory.cpp:273:16: error: expected id-expression before ‘(’ token
  273 |     int fd = ::dirfd(static_cast< DIR* >(imp.handle));
      |                ^~~~~
In file included from ../../src/posix/close_handles.cpp:88:
../../src/posix/close_handles.cpp: In function ‘void boost::process::v2::posix::detail::close_all(const std::vector<int>&, boost::system::error_code&)’:
../../src/posix/close_handles.cpp:188:21: error: expected id-expression before ‘(’ token
  188 |     auto dir_fd = ::dirfd(dir.get());
      |                     ^~~~~

Note, the above errors should be all that's left hopefully once my recent pull request gets merged.

Special thanks to @NishiOwO for testing boost process on NetBSD using my pull request's branch.

Dominant language
C++
Stars
145
Forks
151
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/process

All issues in boostorg/process

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.