BOOST_PP_VARIADICS_MSVC set incorrectly for EDG in Microsoft emulation mode
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start in preprocessor/config/config.hpp and inspect the condition that sets BOOST_PP_VARIADICS_MSVC, focusing on the interaction between _MSC_VER, EDG, and _MSVC_TRADITIONAL. The issue is done when EDG in Microsoft emulation mode no longer incorrectly sets BOOST_PP_VARIADICS_MSVC to 0; no specific test file is mentioned.
Written by the indexing model from the issue text.
Description
In preprocessor/config/config.hpp, the condition for setting BOOST_PP_VARIADICS_MSVC to 1 is:
# if defined _MSC_VER && _MSC_VER >= 1400 && !defined(__clang__) && (defined(__INTELLISENSE__) || (defined(__INTEL_COMPILER) && __INTEL_COMPILER >= 1700) || !(defined __EDG__ || defined __GCCXML__ || (defined __NVCC__ && defined __CUDACC__) || defined __PATHSCALE__ || defined __DMC__ || defined __CODEGEARC__ || defined __BORLANDC__ || defined __MWERKS__ || defined __SUNPRO_CC || defined __HP_aCC || defined __MRC__ || defined __SC__ || defined __IBMCPP__ || defined __PGI)) && (!defined(_MSVC_TRADITIONAL) || _MSVC_TRADITIONAL)
Unless modified by a customer, when the EDG front end is invoked in Microsoft emulation mode, it defines both _MSC_VER and EDG, with the value of MSVC_TRADITIONAL being set depending on the --[no]_ms_std_preprocessor command-line option. When the EDG front end is invoked emulating the traditional Microsoft preprocessor (currently the default in Microsoft emulation mode), this results in defining BOOST_PP_VARIADICS_MSVC to 0, causing errors when Boost preprocessor variadics are used.
Presumably the fix is simply to remove the "defined EDG" test in this conditional.
- Dominant language
- C++
- Stars
- 118
- Forks
- 76
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boostorg/preprocessor
-
Difficulty 5/5 Over a week Newbie friendliness 38/100
boostorg/preprocessor#65 · 5 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
boostorg/preprocessor#63 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
boostorg/preprocessor#58 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
boostorg/preprocessor#55 ·
-
Documentation format Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
boostorg/preprocessor#52 ·
All issues in boostorg/preprocessor
Similar issues
-
ai_reviewed
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ydb-platform/ydb#53869 · 3 comments ·
-
bug cert blocker needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
project-chip/connectedhomeip#74373 ·
-
upstream update
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conan-io/conan-center-index#31035 ·
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 85/100
vllm-project/vllm-ascend#17329 ·