PR #53 introduced a regression into boost pool

Open
#64 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
backend

Research direction

Start with PR #63, especially its first commit demonstrating the regression and its second commit reverting the change. Review the linked Example 4.1 and the two failing unit tests described in the issue; the work is done when mixed partition sizes no longer regress and the incorrect tests are removed or corrected.

Written by the indexing model from the issue text.

Description

TL;DR: PR #53 seems to be based on a wrong assumption. In fact,simple_segregated_storage in its present form is fundamentally uncapable of handling mixed partition sizes, and cannot be "fixed" to allow that handling without a major change of the implementation. The linked-to Example 4.1, which was a starting point for the "fix", also looks simply wrong and so does the fix itself.

There is a new PR here, which contains further details, including

  • the demonstration of the regression (the 1st commit of the new PR),
  • the reverting of the code change (2nd commit of the new PR) and
  • dropping of the two failing uint tests introduced by PR #53, which are believed to be incorrect.
Dominant language
C++
Stars
58
Forks
52
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/pool

All issues in boostorg/pool

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.