Warning C4459 when building using MSVC

Open
#35 2 comments 0 reactions 1 assignee View on GitHub

@glenfe is already working on this.

Since Feb 23, 2024.

Assessment

This issue has not been assessed yet.

Description

Using multi_array, MSVC (VS 2019, VS 2022) emits the following warnings (using Boost release 1.82.0, but current code in the repo includes the same global variable and argument name):

`C:\lo\build\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(615): warning C4459: declaration of 'extents' hides global declaration

C:\lo\build\workdir\UnpackedTarball\boost\boost/multi_array/base.hpp(69): note: see declaration of 'boost::anonymous-namespace'::extents'

This prevents warning-free builds, or requires pollution of the code with pragmas. Would it be possible to rename the constructor argument name?

Dominant language
C++
Stars
32
Forks
39
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/multi_array

All issues in boostorg/multi_array

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.