Slight innacuracy in `ip_address` `try_value_to` example

Open
#1,124 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
documentation

Research direction

Find the ip_address try_value_to example referenced in the issue and review the handling of the nested conversion result. Update the example so the existing error is returned, then verify that the displayed code preserves the nested error information.

Written by the indexing model from the issue text.

Description

    boost::system::result< unsigned char > oct1
        = try_value_to< unsigned char >( arr[0] );
    if( !oct1 )
        return make_error_code( std::errc::invalid_argument );

This should be

    if( !oct1 )
        return oct1.error();

so as to not discard the error returned from the nested try_value_to (which is going to be more informative and may include a source location).

Dominant language
C++
Stars
478
Forks
110
Avg merge
8d 12h
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/json

All issues in boostorg/json

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.