`transform_iterator` does not work with `std::sort` from libc++ 22
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
Research direction
Start with boost/iterator/transform_iterator.hpp and the repro.cpp example, then compare the transform_iterator behavior used by std::sort with the libc++ 22 diagnostic and the linked LLVM issue. Done means the provided C++17 example compiles successfully with libc++ 22 and sorts the wrapped values.
Written by the indexing model from the issue text.
Description
If the comparator has a templated operator(), sorting through a boost::transform_iterator fails to compile with libc++ 22.
#include <algorithm>
#include <string>
#include <vector>
#include <boost/iterator/transform_iterator.hpp>
template <typename T> struct Wrapper { T item; };
struct Identity {
Wrapper<std::string> &operator()(Wrapper<std::string> &w) const { return w; }
};
struct Cmp {
template <typename T>
bool operator()(const Wrapper<T> &a, const Wrapper<T> &b) const { return a.item < b.item; }
};
int main() {
std::vector<Wrapper<std::string>> v{{"b"}, {"a"}};
typedef boost::transform_iterator<Identity, std::vector<Wrapper<std::string>>::iterator> It;
std::sort(It(v.begin()), It(v.end()), Cmp());
}
$ clang++ -std=c++17 -stdlib=libc++ -c repro.cpp
...
/usr/bin/../include/c++/v1/__algorithm/sift_down.h:55:7: error: no matching function for call to object of type
'Cmp'
55 | if (__comp(__first[__child], __first[__start]))
| ^~~~~~
repro.cpp:14:8: note: candidate template ignored: could not match 'Wrapper' against 'operator_brackets_proxy'
14 | bool operator()(const Wrapper<T> &a, const Wrapper<T> &b) const { return a.item < b.item; }
| ^
...
See also https://github.com/llvm/llvm-project/issues/223290.
- Dominant language
- C++
- Stars
- 23
- Forks
- 70
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boostorg/iterator
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
All issues in boostorg/iterator
Similar issues
-
AuTest Bug Tests
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/trafficserver#13714 ·
-
bug build
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
facebookincubator/velox#19143 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
tenstorrent/tt-metal#57393 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
objectionary/eo-graphs#74 ·