"..." ellipsis operator is generating warnings in C++ >= 26: -Wdeprecated-variadic-comma-omission
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with preprocessed.hpp and the BOOST_FT_ell macro, then trace how it is generated and used in cases with and without preceding arguments. Verify the result in C++26 mode and confirm that the deprecated-variadic-comma-omission warning is no longer produced.
Written by the indexing model from the issue text.
Description
In C++26, it's now deprecated to use constructions like:
void f(int...)
we should explicitly add a comma between the previous arguments and the ellipsis:
void f(int, ...)
In practice, Boost function_types generate quite some warnings in C++26 mode, here is one of them:
/data/mwrep/res/osp/Boost/25-0-0-0/include/boost/function_types/detail/pp_variate_loop/preprocessed.hpp:135:23: error: omission of ',' before varargs '...' is deprecated in C++26 [-Werror=deprecated-variadic-comma-omission]
135 | # define BOOST_FT_ell ...
Since BOOST_FT_ell is sometimes used as the only argument, it's not as easy as just adding a comma at the beginning of BOOST_FT_ell, as there should be a special case for when there is no argument before.
I don't know much about Boost.wave, so I am not sure how to propose a fix here.
- Dominant language
- C++
- Stars
- 9
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boostorg/function_types
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
boostorg/function_types#13 ·
-
BOOST_FT_AUTODETECT_CALLING_CONVENTIONS ignored when including <boost/uuid/random_generator.hpp> Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
boostorg/function_types#7 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
boostorg/function_types#5 · 1 comment ·
All issues in boostorg/function_types
Similar issues
-
ai_reviewed
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ydb-platform/ydb#53869 · 3 comments ·
-
bug cert blocker needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
project-chip/connectedhomeip#74373 ·
-
upstream update
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conan-io/conan-center-index#31035 ·
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 85/100
vllm-project/vllm-ascend#17329 ·