`path` methods taking `codecvt` should perform `char`<->`char` code conversion

Open
#257 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp

Research direction

Start with the path constructor, assignment, and appending overloads that accept codecvt_type, then compare their behavior with the cited filesystem standard clauses. Verify the char-to-char case performs conversion through wchar_t and then through path::codecvt(); done means all affected overloads follow that two-stage conversion.

Written by the indexing model from the issue text.

Description

Currently, constructor/assignment/appending methods that accept codecvt_type arguments only perform character code conversion when the source character type does not match path::value_type. C++ standard requires (e.g. here and here) that when both path::value_type and source value type are char the conversion is performed twice: first, from source encoding to wchar_t using the supplied codecvt_type facet, then from wchar_t to native path character encoding using path::codecvt().

Dominant language
C++
Stars
180
Forks
168
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/filesystem

All issues in boostorg/filesystem

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.