Consider removing un-needed memory operation shims
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 50/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- c, wasm
- Domain
- build-system, performance
Research direction
Start with src/mem.c and mem.h, then audit the current call sites in input_init and buf_put against the -O2 -mbulk-memory --gc-sections build. Compare raw and gzipped clayterm.wasm sizes with main using wc -c and gzip -c | wc -c. Done means each shim has a documented keep-or-remove decision, with the build and size measurements supporting it.
Written by the indexing model from the issue text.
Description
src/mem.c currently provides memcpy, memset, strlen, and align8 as freestanding-wasm shims, and PR #32 proposes adding a memmove shim alongside them. Investigation of the linked clayterm.wasm shows that none of these functions survive into the final binary under the current -O2 -mbulk-memory --gc-sections build:
- A non-stripped build links cleanly with zero
memcpy/memset/strlen/align8symbols in the output. input_init— the heaviest caller, containing the trie-building loop over the static cap tables — compiles to zero call instructions. LLVM inlines every constant-sizememset/memcpy, unrolls the trie loop, and constant-foldsstrlenon the literal sequences.buf_put's variable-lengthmemcpylowers directly to amemory.copyinstruction thanks to-mbulk-memory.
In other words, the shims exist purely as a safety net for code the optimizer fails to lower. And if the optimizer fails to lower it, then that is something that should be surfaced, not silently cause our performance to degrade.
Possible Approach
Audit each shim against current call sites and decide case-by-case:
align8— trivial(n + 7) & ~7. Best candidate for a free win: move intomem.hasstatic inlineand drop the definition frommem.c. Before doing so, build and compare raw + gzipped bundle size againstmainto confirm the inline expansion does not regress size (it shouldn't — every call site is already inlined — but it is worth measuring rather than assuming).memset/memcpy— every current call is constant-size or variable-length-with--mbulk-memory-lowering, so both are dead in the linked binary. Keep as a safety net or drop entirely; if dropped, document the requirement that contributors avoid call patterns the optimizer cannot lower.strlen— only foldable because the cap tables are statically initialized literals. A future call on a runtime string (e.g.buf_str(b, user_input)) would re-introduce the link dependency. Lowest-risk shim to keep.memmove(PR #32) — reconsider in light of the above. If we keep the others as defensive shims, merging this one is consistent; if we trim, this one should not land without a real call site.
Decisions should be backed by before/after wc -c and gzip -c | wc -c on clayterm.wasm.
- Dominant language
- TypeScript
- Stars
- 42
- Forks
- 2
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 12
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bombshell-dev/tty
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
bombshell-dev/tty#61 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
bombshell-dev/tty#129 ·
-
question
Difficulty 5/5 Over a week Newbie friendliness 38/100
bombshell-dev/tty#112 ·
-
enhancement high priority
Difficulty 3/5 1-2 days Newbie friendliness 68/100
bombshell-dev/tty#83 · 2 comments ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
bombshell-dev/tty#82 ·
All issues in bombshell-dev/tty
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
safetrustcr/dApp-SafeTrust#426 ·
-
area:workflow bug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
fil-donadoni/tolaria#4409 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Fission-AI/OpenSpec#1960 ·
-
Add dependabot Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
corsairdev/corsair#1764 ·