boltgolt/howdy

Should snapshots be readable for everyone?

Open

#397 opened on Jul 16, 2020

View on GitHub
 (7 comments) (1 reaction) (0 assignees)Python (268 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,836 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I had a look around for the snapshot folder and discovered that the file in it was readable for everyone, I also tried opening it in an image viewing program and that worked. The permissions on it are: -rw-rw-r-- root <my user's group> /usr/lib/security/howdy/snapshots/20200716T180150.jpg

OS: Kubuntu 20.04 Howdy version: 2.6.0

Contributor guide

Research direction
Inspect the code where snapshot files are created and adjust the permissions to be more restrictive (e.g., 600).
Tech stack
python
Domain
security
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80