bluzi/name-db

Review deployment script

Open

#191 opened on Oct 27, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (220 forks)github user discovery
good first issuehacktoberfesthelp wanted

Repository metrics

Stars
 (60 stars)
PR merge metrics
 (PR metrics pending)

Description

I recently added a deployment script and Travis deployment

I'd love if someone review it and write in this issue if there are things that could be better implemented.

Thanks!

Some info about what this script actually does: Every time a branch/pull request is being merged to the master branch, Travis execute the deployment script atdeploy/deploy.collections.js. This script connects to a MySQL database, checks to see what changed in collection/, and updates the database. (removes/changes/adds data, so it'll be exactly like collection/)

The MySQL database from above, is being used by the API to deliver the data. (see code)

Contributor guide

Research direction
Review the deployment script and Travis config for potential improvements in error handling, security, and efficiency.
Tech stack
javascriptmysql
Domain
devops
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitMySQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80