bluealloy/revm

Refactor: migrate from call local refund to global journal refund

Open

#2145 opened on Mar 5, 2025

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Rust (2,194 stars) (1,019 forks)user submission
good first issue

Description

Presently, refund is call local and returned back with the gas when the call is finished, this can result in negative refund being returned and is a unexpected value for tracing.

Having one global refund inside the journal would mitigate this, on the one hand, it will slighlty leak gas calc into journal that is database, but on other hand it (should) encapsulate any refund inside of it additionally removing negative refund case.

Contributor guide

Tech stack
rust
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Ethereum Virtual Machine basicsRust programmingfamiliarity with revm journal
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Examine the current refund implementation in the journal and call context. Review the comments on the issue for any proposed approach. Look at how refund is returned and stored locally. Implement a global refund variable within the journal struct, ensuring to adjust gas calculation accordingly. Test edge cases like nested calls and refund limits.